[FQ2I] Disable rewrite of avg_pool2d op#13323
Closed
ibsidorenko wants to merge 1 commit intoapache:mainfrom
Closed
[FQ2I] Disable rewrite of avg_pool2d op#13323ibsidorenko wants to merge 1 commit intoapache:mainfrom
ibsidorenko wants to merge 1 commit intoapache:mainfrom
Conversation
This commit fixes the following issue: For the sequence of qnn.dequantize -> avg_pool2d -> conv2d -> qnn.quantize FQ2I pass inserts qnn.requantize (or cast) to int32 unconditionally before avg_pool2d. As a result fake quantized qnn.conv2d gets input as int32 dtype, but it is forbidden for qnn.conv2d (supports only uint8/int8/int16). This commit disables such behavoir and support int8/uint8 as input dtype for avg_pool2d in compute function. Also this commit fixes bug#12381.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the following issue:
For the sequence of ops qnn.dequantize -> avg_pool2d -> conv2d -> qnn.quantize FQ2I pass inserts qnn.requantize (or cast) to int32 unconditionally before avg_pool2d. As a result fake quantized qnn.conv2d gets input as int32 dtype, but it is forbidden for qnn.conv2d (supports only uint8/int8/int16).
This commit disables such behavoir and support int8/uint8 as input dtype for avg_pool2d in compute function.
Also this commit fixes bug#12381.