[TVMScript] Output elif where possible#13433
Merged
junrushao merged 1 commit intoapache:mainfrom Nov 19, 2022
Merged
Conversation
When a TIR `IfThenElseNode::else_case` is itself a `IfThenElse` node, it may be printed as `elif` instead of `else: if ...`. The `elif` syntax was already handled on the parsing side, so this commit only changes the TVMScript printer. This change also incidentally altered the printer's output for an else block whose condition is `True`. Previously, these were dropped from the output altogether. Now, they are retained in the else block. Removing no-op statements should be done by a transformation pass, not a printer/parser round trip, so this change in behavior makes sense to keep.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
yelite
approved these changes
Nov 18, 2022
Contributor
yelite
left a comment
yelite
left a comment
There was a problem hiding this comment.
This looks good! Thanks for making this improvement!
shingjan
reviewed
Nov 18, 2022
| doc << Doc::NewLine(); | ||
| doc << "else:" << Doc::Indent(4, Doc::NewLine() << PrintBody(op->else_case.value())); | ||
|
|
||
| Optional<Stmt> else_case = op->else_case; |
There was a problem hiding this comment.
would that be possible that we can add a comment here or a code snippet in the PR to show the elif print before and after this change. Otherwise LGTM.
Contributor
Author
There was a problem hiding this comment.
Certainly! Added a quick example to the PR description.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
When a TIR `IfThenElseNode::else_case` is itself a `IfThenElse` node, it may be printed as `elif` instead of `else: if ...`. The `elif` syntax was already handled on the parsing side, so this commit only changes the TVMScript printer. This change also incidentally altered the printer's output for an else block whose condition is `True`. Previously, these were dropped from the output altogether. Now, they are retained in the else block. Removing no-op statements should be done by a transformation pass, not a printer/parser round trip, so this change in behavior makes sense to keep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TIR
IfThenElseNode::else_caseis itself aIfThenElsenode, it may be printed aselifinstead ofelse: if .... Theelifsyntax was already handled on the parsing side, so this commit only changes the TVMScript printer.This change also incidentally altered the printer's output for an else block whose condition is
True. Previously, these were dropped from the output altogether. Now, they are retained in the else block. Removing no-op statements should be done by a transformation pass, not a printer/parser round trip, so this change in behavior makes sense to keep.Below are shown the same prim func, printed before and after this change.