[ACL] Enable int8 data type in QNN DENSE#13487
Merged
lhutton1 merged 1 commit intoapache:mainfrom Nov 28, 2022
Merged
Conversation
This enables int8 data type to be used in Compute Library for the Arm(r) Architecture (ACL) BYOC integration. Change-Id: Ib954fcbb98cc031ca10094bc53d8bd7710b7fb9e
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
asparkhi
reviewed
Nov 25, 2022
Contributor
asparkhi
left a comment
asparkhi
left a comment
There was a problem hiding this comment.
It is pleasantly surprising that the codegen does not require any changes when supporting a new dtype. It shows that the ACL APIs and their integration into TVM is seamless 🚀
These changes look good to me modulo a minor comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
QNN_DENSEint8 data type to be used in Compute Library for the Arm(r) Architecture (ACL) BYOC integration.cc @lhutton1 for reviews