[Docs][Bug] Fix broken link to tvmc python#13499
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
@bkmgit @leandron Shouldn't that be pointing to https://github.com/apache/tvm/blob/main/gallery/tutorial/autotvm_relay_x86.py#L18 instead? |
|
@gromero Thanks for your feedback. That is not the next tutorial in the sequence obtained at the bottom of the page . The link you have suggested could be used but then it would be helpful to rephrase In the next tutorial, Compiling and Optimizing a Model with the Python Interface, to In the next tutorial, we introduce the Python interface to TVM, and in the tutorial after that, |
@bkmgit Got it!
yeah I'm ok with that version. Another option would be to just adjusting the text in your change, i.e. in "In the next tutorial, Getting Starting using TVMC Python: a high-level API for TVM, we introduce the Python interface to TVM." and move the second part to the bottom of tutorial tvmc_python.py. "In the next tutorial, Compiling and Optimizing a Model with the Python Interface, we will cover the same compilation and optimization steps using the Python interface." But either way works for me. |
There was a problem hiding this comment.
@bkmgit The important thing here I think is to keep the text matching the fixed link, either by updating the text to match the tvmc_pyton.py tutorial title or by removing the stale text that became outdated by the new (fixed) link.
|
@gromero Thanks for the feedback. Done. |
Ensure correct link is generated to the next page in the documentation. Update description to indicate next section introduces Python API, and the section after that discusses the same material but using Python rather than the command line interface.
|
@leandron Since there are changes since your last review, would you like to take another look? Thanks! |
Ensure correct link is generated to the next page in the documentation.