Skip to content

Mark base64.h encode and decode API's as inline#13556

Merged
masahi merged 1 commit intoapache:mainfrom
f2013519:main
Dec 6, 2022
Merged

Mark base64.h encode and decode API's as inline#13556
masahi merged 1 commit intoapache:mainfrom
f2013519:main

Conversation

@f2013519
Copy link
Contributor

@f2013519 f2013519 commented Dec 6, 2022

The b64strlen & b64decode API's are defined in a header and will cause linker issues if included in multiple files. We ran into this issue while attempting to use this file in our project.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 6, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to auto-tag found, no teams are specified in PR title See #10317 for details
  • Built docs for commit 1b27629 can be found here.

Generated by tvm-bot

@f2013519
Copy link
Contributor Author

f2013519 commented Dec 6, 2022

cc @masahi Could you pls. take a look, thanks.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thanks for the contribution!

@masahi masahi merged commit 8826c1c into apache:main Dec 6, 2022
@masahi
Copy link
Member

masahi commented Dec 6, 2022

@f2013519 Good catch!

@f2013519
Copy link
Contributor Author

f2013519 commented Dec 7, 2022

Thanks!

mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants