Mark base64.h encode and decode API's as inline#13556
Merged
masahi merged 1 commit intoapache:mainfrom Dec 6, 2022
f2013519:main
Merged
Mark base64.h encode and decode API's as inline#13556masahi merged 1 commit intoapache:mainfrom f2013519:main
masahi merged 1 commit intoapache:mainfrom
f2013519:main
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
cc @masahi Could you pls. take a look, thanks. |
junrushao
approved these changes
Dec 6, 2022
Member
junrushao
left a comment
There was a problem hiding this comment.
That makes sense. Thanks for the contribution!
Member
|
@f2013519 Good catch! |
Contributor
Author
|
Thanks! |
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The b64strlen & b64decode API's are defined in a header and will cause linker issues if included in multiple files. We ran into this issue while attempting to use this file in our project.