Skip to content

[ci] Fix upload_ci_resource.yml and update related documentation#13562

Merged
driazati merged 2 commits intoapache:mainfrom
guberti:ci/fix-request-hook-comment
Dec 6, 2022
Merged

[ci] Fix upload_ci_resource.yml and update related documentation#13562
driazati merged 2 commits intoapache:mainfrom
guberti:ci/fix-request-hook-comment

Conversation

@guberti
Copy link
Member

@guberti guberti commented Dec 6, 2022

The workflow https://github.com/apache/tvm/actions/workflows/upload_ci_resource.yml uses SHA-256, not SHA-512 hashes. This PR fixes a comment in request_hook.py to reflect this, and fixes some other formatting too.

It also adds a trailing quote to `upload_ci_resource.yml' to prevent it from failing (e.g. https://github.com/apache/tvm/actions/runs/3629030778/jobs/6120748470).

@driazati can you review and merge?

@guberti guberti requested a review from driazati December 6, 2022 11:57
@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 6, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@guberti guberti changed the title Fix upload_ci_resource.yml and update related documentation [ci] Fix upload_ci_resource.yml and update related documentation Dec 6, 2022
@apache apache deleted a comment from tvm-bot Dec 6, 2022
@driazati driazati merged commit 8d04e1e into apache:main Dec 6, 2022
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…che#13562)

The workflow https://github.com/apache/tvm/actions/workflows/upload_ci_resource.yml uses SHA-256, not SHA-512 hashes. This  PR fixes a comment in `request_hook.py` to reflect this, and fixes some other formatting too.

It also adds a trailing quote to `upload_ci_resource.yml' to prevent it from failing (e.g. https://github.com/apache/tvm/actions/runs/3629030778/jobs/6120748470).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants