[Unity][Frontend] FX exp and strided_slice fix#14338
Merged
tqchen merged 1 commit intoapache:unityfrom Mar 20, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
1 similar comment
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
psrivas2
reviewed
Mar 20, 2023
|
|
||
| graph_model = fx.symbolic_trace(torch_model) | ||
| mod = from_fx(graph_model, input_info) | ||
| print(mod.script()) |
Contributor
There was a problem hiding this comment.
left over debug statement?
Contributor
Author
There was a problem hiding this comment.
Yes sorry for that. Just removed it.
psrivas2
approved these changes
Mar 20, 2023
Contributor
|
LGTM! just one left over print statement |
* Add the support of `exp` for the FX translator. * Previously the way FX translator dealt with `None` in torch tensor slice (e.g., `x[:, None, None]`) is not right. This PR fixes this issue. Specifically, the `None` here means dim expansion, and the previous impl mistakenly increases the dim counter when seeing `None`, which will lead to dim counter out-of-range issue in the end.
MasterJH5574
force-pushed
the
unity-dev/2023-03-19-fx-exp-strided-slice
branch
from
fae4a65 to
05ea131
Compare
tqchen
approved these changes
Mar 20, 2023
tqchen
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Add the support of `exp` for the FX translator. * Previously the way FX translator dealt with `None` in torch tensor slice (e.g., `x[:, None, None]`) is not right. This PR fixes this issue. Specifically, the `None` here means dim expansion, and the previous impl mistakenly increases the dim counter when seeing `None`, which will lead to dim counter out-of-range issue in the end.
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
* Add the support of `exp` for the FX translator. * Previously the way FX translator dealt with `None` in torch tensor slice (e.g., `x[:, None, None]`) is not right. This PR fixes this issue. Specifically, the `None` here means dim expansion, and the previous impl mistakenly increases the dim counter when seeing `None`, which will lead to dim counter out-of-range issue in the end.
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
* Add the support of `exp` for the FX translator. * Previously the way FX translator dealt with `None` in torch tensor slice (e.g., `x[:, None, None]`) is not right. This PR fixes this issue. Specifically, the `None` here means dim expansion, and the previous impl mistakenly increases the dim counter when seeing `None`, which will lead to dim counter out-of-range issue in the end.
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
* Add the support of `exp` for the FX translator. * Previously the way FX translator dealt with `None` in torch tensor slice (e.g., `x[:, None, None]`) is not right. This PR fixes this issue. Specifically, the `None` here means dim expansion, and the previous impl mistakenly increases the dim counter when seeing `None`, which will lead to dim counter out-of-range issue in the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expfor the FX translator.Nonein torch tensor slice (e.g.,x[:, None, None]) is not right. This PR fixes this issue. Specifically, theNonehere means dim expansion, and the previous impl mistakenly increases the dim counter when seeingNone, which will lead to dim counter out-of-range issue in the end.