[Unity][Op][Docs] Update comment for call_tir_dyn#14441
Merged
tqchen merged 1 commit intoapache:unityfrom Mar 31, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
Update comment for call_tir_dyn
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
Update comment for call_tir_dyn
tqchen
pushed a commit
that referenced
this pull request
Apr 1, 2023
Update comment for call_tir_dyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment for the
vm.call_tir_dynoperator was out of date. This PR corrects it with a more applicable distinction.Note: I was still unable to figure out what it actually does. Only a TVMScript parsing test actually uses this op. tlc-pack/relax#57 was the PR that introduced it and it also does not include a very specific description. If anybody could tell me how exactly the op works, I will update the description to be more precise.