[Relay] Move pad value extraction past null pointer check#14444
Closed
kparzysz-quic wants to merge 1 commit intoapache:mainfrom
kparzysz-quic:pad-value-nullptr
Closed
[Relay] Move pad value extraction past null pointer check#14444kparzysz-quic wants to merge 1 commit intoapache:mainfrom kparzysz-quic:pad-value-nullptr
kparzysz-quic wants to merge 1 commit intoapache:mainfrom
kparzysz-quic:pad-value-nullptr
Conversation
In SimplifyExplicitPad, the pad_value pointer was dereferenced before checking if it's null or not. Move the dereference to past the check.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SimplifyExplicitPad, the pad_value pointer was dereferenced before checking if it's null or not. Move the dereference to past the check.