Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
force-pushed
the
arange_op
branch
2 times, most recently
from
64359c1 to
662930e
Compare
slyubomirsky
approved these changes
Apr 3, 2023
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
This all looks reasonable, thanks!
The current `arange` op in PyTorch is converted as constant at frontend, however, it does not work when the length is dynamic. This PR adds `arange` op to relax, and use different rules when legalization: - If the length is fixed, we will convert it to constant. - If the length is dynamic, we use `topi.arange` to compute it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
arangeop in PyTorch is converted as constant at frontend, however, it does not work when the length is dynamic.This PR adds
arangeop to relax, and use different rules when legalization:topi.arangeto compute it.