Skip to content

[Unity] Memory planning with TIR var upper bound#14511

Merged
spectrometerHBH merged 1 commit into
apache:unityfrom
MasterJH5574:unity-dev/2023-04-05-mem-plan-sym
Apr 5, 2023
Merged

[Unity] Memory planning with TIR var upper bound#14511
spectrometerHBH merged 1 commit into
apache:unityfrom
MasterJH5574:unity-dev/2023-04-05-mem-plan-sym

Conversation

@MasterJH5574

Copy link
Copy Markdown
Contributor

This PR enhances the memory planning pass with TIR var upper bound
annotation, so that it supports dynamic shape cases when we have
an estimate for the maximum values of the dynamic vars.

@tvm-bot

tvm-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

1 similar comment
@tvm-bot

tvm-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@MasterJH5574

MasterJH5574 commented Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

Depends on #14509.

@MasterJH5574 MasterJH5574 force-pushed the unity-dev/2023-04-05-mem-plan-sym branch from 1bc37a8 to 0f473e1 Compare April 5, 2023 17:41
Comment thread src/relax/transform/static_plan_block_memory.cc Outdated
@MasterJH5574 MasterJH5574 force-pushed the unity-dev/2023-04-05-mem-plan-sym branch from 0f473e1 to 2404a84 Compare April 5, 2023 17:45

@tqchen tqchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits and LGTM

Comment thread src/relax/transform/static_plan_block_memory.cc Outdated
@MasterJH5574 MasterJH5574 force-pushed the unity-dev/2023-04-05-mem-plan-sym branch from 2404a84 to 3129a61 Compare April 5, 2023 17:52
Comment thread src/relax/transform/static_plan_block_memory.cc Outdated
This PR enhances the memory planning pass with TIR var upper bound
annotation, so that it supports dynamic shape cases when we have
an estimate for the maximum values of the dynamic vars.
@MasterJH5574 MasterJH5574 force-pushed the unity-dev/2023-04-05-mem-plan-sym branch from 3129a61 to 5d66717 Compare April 5, 2023 18:58
@yzh119

yzh119 commented Apr 5, 2023

Copy link
Copy Markdown
Member

In SparseTIR we have statements like T.assume_bound, and we might unify them in the future :)

@spectrometerHBH spectrometerHBH merged commit bd003e8 into apache:unity Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants