[Unity][Op] Gradient functions for high-level Relax operators#14527
Merged
tqchen merged 5 commits intoapache:unityfrom Apr 8, 2023
Merged
[Unity][Op] Gradient functions for high-level Relax operators#14527tqchen merged 5 commits intoapache:unityfrom
tqchen merged 5 commits intoapache:unityfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Member
|
@SiriusNEO one minor note, make sure you append the co-author commit message to the end |
yongwww
reviewed
Apr 7, 2023
Co-authored-by: Yixin Dong <ubospica@gmail.com>
2bfe776 to
7ecef07
Compare
tqchen
approved these changes
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intro
This PR registers gradient functions for many high-level Relax operators. Similar with Relay, the gradient function is registered as an attribute
FPrimalGradient(OpAttr) of corresponding Relax operators. But the function signature is different from Relay:orig_callis the orginal call expr which we want to differentiate.output_gradis the gradient of RHS.orig_varisy. It is passed to saving some calculations.ctxis the context which is not used right now. But we believe it is useful when it comes to dynamic shape cases and when we need to emit some bindings or do some normalizations.For some complicate gradient functions, we introduce some high-level backward operators and put them under the namespace
op.grad.xxx. All gradient functions are well tested (numerically). For more details please check Part 2 of this document.Others
Also this PR fixes two small problems about op:
CumsumAttrsisn't declared in the Python side.variance.Co-authored-by: Yixin Dong ubospica@gmail.com