[Unity][CUTLASS] Fixed stacked attention offload when QKV reshape uses the same shape expression#14728
Merged
masahi merged 2 commits intoapache:unityfrom Apr 27, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
cyx-6
approved these changes
Apr 26, 2023
Contributor
cyx-6
left a comment
There was a problem hiding this comment.
Thanks for reporting and fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a single expression, such as
R.shape([2, 4096, 8, 40])is used by allreshapefor QKV, the following composite function that only gets one shape parameter is generated. This is currently not handled properly by codegen.Apparently, it is due to
EliminateCommonSubexpr()pass that I'm using which turns the original threereshapeops below into ones that share the sameR.shape([2, 4096, 8, 40]).@cyx-6