[Unity] Add system lib build option to relax#14734
Merged
MasterJH5574 merged 1 commit intoapache:unityfrom Apr 27, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
This PR add system lib build option to relax also adds an util that creates an archived static library in compilation
junrushao
approved these changes
Apr 27, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM! BTW, the name "system lib" has been around for a while, but less known to introductory users, so shall we clarify why it is named this way?
Member
Author
|
Good suggestion, that is a great topic for discussion. |
MasterJH5574
approved these changes
Apr 27, 2023
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Apr 28, 2023
This PR add system lib build option to relax also adds an util that creates an archived static library in compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add system lib build option to relax
also adds an util that creates an archived static
library in compilation