[Unity][Training] Categorical cross entropy loss#14757
Merged
echuraev merged 1 commit intoapache:unityfrom May 12, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
echuraev
changed the title
echuraev
reviewed
May 4, 2023
Contributor
There was a problem hiding this comment.
Thank you for the PR. Please fix issues in CI. I added a minor comment. @Ubospica, @SiriusNEO could you please review this PR?
echuraev
reviewed
May 4, 2023
SiriusNEO
approved these changes
May 4, 2023
Contributor
SiriusNEO
left a comment
SiriusNEO
left a comment
There was a problem hiding this comment.
Overall looks great, just a few comments.
ndemashov
force-pushed
the
mlc-dev/categorical_cross-entropy_loss
branch
from
c370d7f to
63d0cc7
Compare
echuraev
reviewed
May 4, 2023
ndemashov
force-pushed
the
mlc-dev/categorical_cross-entropy_loss
branch
from
63d0cc7 to
4edda8a
Compare
Contributor
|
@tvm-bot rerun |
ndemashov
force-pushed
the
mlc-dev/categorical_cross-entropy_loss
branch
6 times, most recently
from
0674bec to
03d625c
Compare
Contributor
|
@tvm-bot rerun |
1 similar comment
Contributor
|
@tvm-bot rerun |
fix lint Add targets dtype checker and description of the reason for two implementations Lift the common part fix dtype checker fix lint
ndemashov
force-pushed
the
mlc-dev/categorical_cross-entropy_loss
branch
from
03d625c to
775edc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support of categorical cross entropy loss