[Unity] Fix CUDA graph rewrite var used before def#14800
Merged
masahi merged 1 commit intoapache:unityfrom May 10, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
masahi
approved these changes
May 8, 2023
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
Confirmed that this fixes the issue I had. Need to fix lint.
Member
|
@vinx13 Please remove this debug log https://github.com/apache/tvm/blob/unity/src/runtime/relax_vm/cuda/cuda_graph_builtin.cc#L90 |
vinx13
force-pushed
the
unity-fix-cuda-graph
branch
from
1f12f97 to
b38e94a
Compare
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/4929585866 Detailswith response |
CUDA graph rewriting may result reordering of original bindings, for example when a variable is used as an input of the lifted function. If the variable comes from the output of another function, we need to make sure output unpacking is emitted.
vinx13
force-pushed
the
unity-fix-cuda-graph
branch
from
b38e94a to
baa5bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA graph rewriting may result reordering of original bindings, for example when a variable is used as an input of the lifted function. If the variable comes from the output of another function, we need to make sure output unpacking is emitted.