Skip to content

[Unity] Fix FewShotTuning Failure When Missing Global Symbol#15097

Merged
masahi merged 1 commit intoapache:unityfrom
zxybazh:bugfix/2023-06-09/fix-few-shot-tuning-no-global-symbol
Jun 13, 2023
Merged

[Unity] Fix FewShotTuning Failure When Missing Global Symbol#15097
masahi merged 1 commit intoapache:unityfrom
zxybazh:bugfix/2023-06-09/fix-few-shot-tuning-no-global-symbol

Conversation

@zxybazh
Copy link
Copy Markdown
Member

@zxybazh zxybazh commented Jun 13, 2023

Previously the building of PrimFuncs in Few Shot Tuning pass will fail when the function attribute global_symbol is missing. This PR manually adds a global symbol of main for each PrimFunc to tune and the unit tests are modfied accordingly.

Thanks @masahi for identifying this issue.

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Jun 13, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@masahi masahi merged commit 4347b30 into apache:unity Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants