[TIR] Blockize keeping T.init in inner block when outer block does no reduction#15251
Closed
MasterJH5574 wants to merge 1 commit intoapache:mainfrom
Closed
[TIR] Blockize keeping T.init in inner block when outer block does no reduction#15251MasterJH5574 wants to merge 1 commit intoapache:mainfrom
MasterJH5574 wants to merge 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
|
… reduction This PR enhances the behavior of tir.Schedule.blockize, so that when the outer block after blockization does no effective reduction, the `T.init` part will be kept in the inner block. No new unit test is added as the update of the existing tests in this PR has already covered the correctness and ensured the expected behavior. Co-authored-by: Bohan Hou <spectrometerh@gmail.com>
MasterJH5574
force-pushed
the
tvm-dev/2023-07-05-blockize-init
branch
from
54e920c to
6074d12
Compare
yzh119
approved these changes
Jul 6, 2023
|
|
||
| if __name__ == "__main__": | ||
| tvm.testing.main() | ||
| test_blockize_outer() |
Contributor
Author
|
Closed since the intention of this PR seems to break MS tuning which is more complicated for fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the behavior of tir.Schedule.blockize, so that when the outer block after blockization does no effective reduction, the
T.initpart will be kept in the inner block.No new unit test is added as the update of the existing tests in this PR has already covered the correctness and ensured the expected behavior.
Co-authored-by: Bohan Hou spectrometerh@gmail.com