[Unity][Relax][Transform] Do not remove MatchCast for RemoveAllUnused#15290
Merged
Hzfengsy merged 1 commit intoapache:unityfrom Jul 13, 2023
Merged
[Unity][Relax][Transform] Do not remove MatchCast for RemoveAllUnused#15290Hzfengsy merged 1 commit intoapache:unityfrom
Hzfengsy merged 1 commit intoapache:unityfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
if we call @R.function
def main(
shape_tensor: R.Tensor((3,), dtype="int64")
) -> R.Tensor(dtype="int32", ndim=3):
m = T.int64()
n = T.int64()
k = T.int64()
with R.dataflow():
lv: R.Shape(ndim=3) = R.call_pure_packed(
"vm.builtin.tensor_to_shape", shape_tensor, sinfo_args=(R.Shape(ndim=3),)
)
lv1: R.Shape([m, n, k]) = R.match_cast(lv, R.Shape([m, n, k]))
lv2: R.Tensor((m, 1, k), dtype="int32") = R.full(
R.shape([m, 1, k]), R.const(1, "int32"), dtype="int32"
)
gv: R.Tensor((m, 1, k), dtype="int32") = lv2
R.output(gv)
return gv |
Member
|
Thanks for the fixing. Could you please add a regression test, i.e., a test case that fails before this fix but passes after this patch? |
Contributor
Author
sure |
Contributor
Author
|
add regression test |
Hzfengsy
approved these changes
Jul 11, 2023
Match_cast can be used to capture symbolic shapes, remove MatchCast binding will cause `Prim Expr xxx has not been computed` in build stage.
Member
|
Please fix the CI and we can get it in |
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/5531296114 Detailswith response |
Member
|
cc @slyubomirsky @ganler as well |
Member
|
A likely better approach is to also analyze the use of symbolic vars and remove match-cast if the generated symbolic vars are not referenced in followup struct info and Exprs. But this is a good first step to ensure correctness |
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 15, 2023
…apache#15290) Match_cast can be used to capture symbolic shapes, remove MatchCast binding will cause `Prim Expr xxx has not been computed` in build stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match_cast can be used to capture symbolic shapes, remove MatchCast binding will cause
Prim Expr xxx has not been computedin build stage.