[Unity] Fix FuseOpsByPattern when a subgraph can be matched by multiple residual patterns#15308
Merged
vinx13 merged 1 commit intoapache:unityfrom Jul 14, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
residual patterns
976b60d to
d91819d
Compare
yelite
approved these changes
Jul 13, 2023
vinx13
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this subgraph:
This subgraph matches to two different residual patterns
matmul -> add -> addstarting from each matmul and matching two out of threeadds. Currently we end up generating the following partition, since the secondaddmatches to both residual patterns and the two groups are merged incorrectly after the second matching.This bug has been fixed by checking, on successful pattern matching, whether there exists a matched expression that is part of a previously matched group.
@yelite @vinx13