[Unity][Dlight] Rule matmul avoiding blockIdx.z#15333
Merged
yzh119 merged 1 commit intoapache:unityfrom Jul 17, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
1 similar comment
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
cc @Hzfengsy |
yzh119
approved these changes
Jul 16, 2023
Member
yzh119
left a comment
yzh119
left a comment
There was a problem hiding this comment.
LGTM, thank you for the patch.
Prior to this PR, the matmul rule of dlight binds loops to `blockIdx.z`. However, not every device supports this blockIdx dimension (for example, WebGPU does not support `blockIdx.z`), which makes dlight fails to apply and build. Therefore, this PR fuses the `blockIdx.z` loop with other `blockIdx` loop.
MasterJH5574
force-pushed
the
unity-dev/2023-07-16-matmul-blockidxz
branch
from
3ae8a6e to
f0c62de
Compare
junrushao
pushed a commit
that referenced
this pull request
Jul 18, 2023
Prior to this PR, the matmul rule of dlight binds loops to `blockIdx.z`. However, not every device supports this blockIdx dimension (for example, WebGPU does not support `blockIdx.z`), which makes dlight fails to apply and build. Therefore, this PR fuses the `blockIdx.z` loop with other `blockIdx` loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the matmul rule of dlight binds loops to
blockIdx.z. However, not every device supports this blockIdx dimension (for example, WebGPU does not supportblockIdx.z), which makes dlight fails to apply and build.Therefore, this PR fuses the
blockIdx.zloop with otherblockIdxloop.