[Unity] Fix the ambiguity issue in vDevice constructor on Mac with Apple clang version 14.0.3#15546
Merged
yongwww merged 3 commits intoapache:unityfrom Aug 15, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
approved these changes
Aug 13, 2023
Member
yongwww
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #15447 introduces
vDeviceand currently, it causes compilation failure on my Mac with the following error:This occurs due to the ambiguity with the default constructor defined within
TVM_DEFINE_OBJECT_REF_METHODS.Therefore, this PR eliminates such ambiguity by explicitly calling the constructor.
Since it requires explicit passing of the default arguments, I'd like to find a way to support previous usage (e.g.,
VDevice()) without the ambiguity. But I don't have good idea at the moment unfortunately.cc. @yongwww