[Unity][Transform] Track callees from external functions in DeadCodeElimination#15561
Merged
csullivan merged 1 commit intoapache:unityfrom Aug 25, 2023
Merged
Conversation
Prior to this commit, the DeadCodeElimination pass avoided removing externally-exposed functions, only checked for callees from user-specified functions. If an external function wasn't specified, the dead-code elimination could remove a callee resulting in a dangling `GlobalVar`. This commit updates the dead code elimination to treat all externally-exposed functions as potential entry points. User-specified functions can still be provided, and are treated as additional entry points.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
csullivan
approved these changes
Aug 25, 2023
csullivan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the DeadCodeElimination pass avoided removing externally-exposed functions, only checked for callees from user-specified functions. If an external function wasn't specified, the dead-code elimination could remove a callee resulting in a dangling
GlobalVar.This commit updates the dead code elimination to treat all externally-exposed functions as potential entry points. User-specified functions can still be provided, and are treated as additional entry points.