[Unity][Frontend][NN] Make effects optional in nn module.#15650
Merged
junrushao merged 6 commits intoapache:unityfrom Sep 2, 2023
Merged
[Unity][Frontend][NN] Make effects optional in nn module.#15650junrushao merged 6 commits intoapache:unityfrom
junrushao merged 6 commits intoapache:unityfrom
Conversation
junrushao
reviewed
Aug 31, 2023
junrushao
approved these changes
Sep 1, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM. A minor comment. Feel free to skip as a follow-up PR
| def export_tvm( | ||
| self, | ||
| spec: "_spec.ModuleSpecType", | ||
| debug: bool = False, |
Member
There was a problem hiding this comment.
Shall we also add this debug flag to the jit method?
Member
There was a problem hiding this comment.
Oh actually you will need the debug flag in line 405
Contributor
Author
There was a problem hiding this comment.
Good point, now added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
debugargument toexport_tvm. WhendebugisFalse, effects are not included in the output graph. This can make deploying models less cumbersome since its not often theyll use effects. I also added automatic annotation of thenum_inputsfunction attribute since it is useful for a few passes.