[Runtime] Refactor NDArrayCache Support#15659
Merged
tqchen merged 1 commit intoapache:unityfrom Sep 2, 2023
Merged
Conversation
This PR refactors the NDArrayCache support with the following changes: - Support loading metadata from a string rather than a concrete JSON file on disc; - Remove dependency to std::filesystem as it is not well supported in certain platforms yet. Details: apache#15654 (comment). - Simplify format used in `shard-info.json` as detailed below: ``` // Existing format [ { "name": "x0", "shard_dim": 0, }, { "name": "x1", "shard_dim": 1, } ] // New format { "x0": 0, "x1": 1, } ```
Member
Author
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Sep 2, 2023
This PR refactors the NDArrayCache support with the following changes: - Support loading metadata from a string rather than a concrete JSON file on disc; - Remove dependency to std::filesystem as it is not well supported in certain platforms yet. Details: apache#15654 (comment). - Simplify format used in `shard-info.json` as detailed below: ``` // Existing format [ { "name": "x0", "shard_dim": 0, }, { "name": "x1", "shard_dim": 1, } ] // New format { "x0": 0, "x1": 1, } ```
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Sep 2, 2023
This PR refactors the NDArrayCache support with the following changes: - Support loading metadata from a string rather than a concrete JSON file on disc; - Remove dependency to std::filesystem as it is not well supported in certain platforms yet. Details: apache#15654 (comment). - Simplify format used in `shard-info.json` as detailed below: ``` // Existing format [ { "name": "x0", "shard_dim": 0, }, { "name": "x1", "shard_dim": 1, } ] // New format { "x0": 0, "x1": 1, } ```
tqchen
approved these changes
Sep 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the NDArrayCache support with the following changes:
ndarray-cache.json#15654 (comment).shard-info.jsonas detailed below: