[Unity] Unwrap tuples during CanonicalizeBindings#15696
Merged
slyubomirsky merged 1 commit intoapache:unityfrom Sep 15, 2023
Merged
[Unity] Unwrap tuples during CanonicalizeBindings#15696slyubomirsky merged 1 commit intoapache:unityfrom
slyubomirsky merged 1 commit intoapache:unityfrom
Conversation
Prior to this commit, `CanonicalizeBindings` would identify trivial bindings of `var_y = var_x` and replace subsequent usage of `var_y` with `var_x`, but bindings of the form `tuple_var = (var_x,); var_y = var_x[0]` would not be canonicalized. This commit updates the `CanonicalizeBindings` pass to identify trivial bindings that occur across a `TupleGetItem` expression, handling them as if they were direct assignments.
Lunderberg
force-pushed
the
unity_canonicalize_binding_across_tuple
branch
from
4495780 to
c013605
Compare
slyubomirsky
approved these changes
Sep 15, 2023
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
Great change, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
CanonicalizeBindingswould identify trivial bindings ofvar_y = var_xand replace subsequent usage ofvar_ywithvar_x, but bindings of the formtuple_var = (var_x,); var_y = var_x[0]would not be canonicalized.This commit updates the
CanonicalizeBindingspass to identify trivial bindings that occur across aTupleGetItemexpression, handling them as if they were direct assignments.