[Unity] Dynamic-shape param support in LazyTransformParams#15713
Merged
junrushao merged 1 commit intoSep 9, 2023
Merged
Conversation
This PR brings the support for dynamic-shape parameters to pass LazyTransformParams. Prior to this PR, the symbolic variables in the dynamic-shape parameters are not properly popped out. This PR uses MatchCast to make sure the symbolic variables are always popped out and thereby support the dynamic-shape parameters. This PR also fixes a previvously failed test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the support for dynamic-shape parameters to pass LazyTransformParams.
Prior to this PR, the symbolic variables in the dynamic-shape parameters are not properly popped out. This PR uses MatchCast to make sure the symbolic variables are always popped out and thereby support the dynamic-shape parameters.
This PR also fixes a previvously failed test.