Skip to content

[Runtime][CUDA] NVTX Integration#15760

Merged
junrushao merged 1 commit into
apache:unityfrom
junrushao:feature/2023-09-15/nvtx-integration
Sep 18, 2023
Merged

[Runtime][CUDA] NVTX Integration#15760
junrushao merged 1 commit into
apache:unityfrom
junrushao:feature/2023-09-15/nvtx-integration

Conversation

@junrushao

@junrushao junrushao commented Sep 15, 2023

Copy link
Copy Markdown
Member

This PR enables NVTX integration with TVM runtime. It exposes the
following interfaces:

TVM_NVTX_FUNC_SCOPE(); // A macro to mark function scope
NVTXScopedRange _scope("my_nvtx_loop"); // An RAII-managed NVTX scope

If TVM is not built against NVTX, those operations will be dissolved as
no-op in runtime with no side effects.

@junrushao

Copy link
Copy Markdown
Member Author

CC: @yzh119 @masahi

@yzh119 yzh119 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread cmake/modules/CUDA.cmake Outdated
@junrushao junrushao force-pushed the feature/2023-09-15/nvtx-integration branch 2 times, most recently from d33358a to 90dc9dd Compare September 18, 2023 00:00
@junrushao junrushao marked this pull request as ready for review September 18, 2023 00:02
@junrushao

Copy link
Copy Markdown
Member Author

This PR is ready for review! CC: @yzh119 @vinx13

This PR enables NVTX integration with TVM runtime. It exposes the
following interfaces:

```
TVM_NVTX_FUNC_SCOPE(); // A macro to mark function scope
NVTXScopedRange _scope("my_nvtx_loop"); // An RAII-managed NVTX scope
```

If TVM is not built against NVTX, those operations will be dissolved as
no-op in runtime with no side effects.
@junrushao junrushao force-pushed the feature/2023-09-15/nvtx-integration branch from 90dc9dd to 906653e Compare September 18, 2023 00:09

@yzh119 yzh119 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao junrushao merged commit 6d085ae into apache:unity Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants