[IR] Use CoW in StmtFunctor to prevent mutating buffer#15794
Closed
vinx13 wants to merge 1 commit intoapache:mainfrom
Closed
[IR] Use CoW in StmtFunctor to prevent mutating buffer#15794vinx13 wants to merge 1 commit intoapache:mainfrom
vinx13 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
@vinx13 we might need to think about possible needs to remap the use site of the buffer, either in the pass, or in followups |
Contributor
|
How large is the performance benefit of This would also minimize surprises for developers, as currently the |
Member
Author
|
superseded by #15816 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @tqchen @junrushao