[Unity][UnitTest] Enable BindParams test for R.Prim#15978
Merged
masahi merged 1 commit intoapache:unityfrom Oct 30, 2023
Merged
[Unity][UnitTest] Enable BindParams test for R.Prim#15978masahi merged 1 commit intoapache:unityfrom
masahi merged 1 commit intoapache:unityfrom
Conversation
This test was implemented in apache#15626, but was initially disabled as it depended on functionality not introduced until apache#15577. Since that PR has landed, cleaning up and enabling the unit test.
6ae68f4 to
2c40869
Compare
Contributor
Author
|
Rebased onto head to re-run CI. Previous failures were present in unity head, and have been resolved. (See this comment for details.) |
masahi
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was implemented in #15626, but was initially disabled as it depended on functionality not introduced until #15577. Since that PR has landed, cleaning up and enabling the unit test.