[Unity] Add LoadParamOnWorker0 function in shard loader#16093
Merged
junrushao merged 2 commits intoapache:unityfrom Nov 10, 2023
Merged
[Unity] Add LoadParamOnWorker0 function in shard loader#16093junrushao merged 2 commits intoapache:unityfrom
junrushao merged 2 commits intoapache:unityfrom
Conversation
Contributor
Author
|
cc: @junrushao |
Member
|
The implementation looks good, but not sure what the best name tbh. @tqchen maybe you could suggest? |
Member
|
How about LoadParamOnWorker0. And for future sharded version we can say LoadShardedParams |
Contributor
Author
|
sounds good |
Member
|
Sounds good! Let’s do that then |
d90eed4 to
a1f198b
Compare
junrushao
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DistIR compilation flow, shard loading is implemented in a Relax func, like
LoadWholeParamOnWorker0 loads the unsharded param on worker0, and for other workers returns an empty array.
This PR implements LoadWholeParamOnWorker0