[Unity][DLight] Enhance the inline consumer rule#16124
Merged
junrushao merged 1 commit intoapache:unityfrom Nov 15, 2023
Merged
[Unity][DLight] Enhance the inline consumer rule#16124junrushao merged 1 commit intoapache:unityfrom
junrushao merged 1 commit intoapache:unityfrom
Conversation
junrushao
approved these changes
Nov 14, 2023
The current inline consumer rule failed on the following case, because
of the missing inline of the producers of the output stage
```
A B D
\ / |
matmul C
\ /
out
```
Hzfengsy
force-pushed
the
improve_dlight_inline_consumers
branch
from
68d6c2c to
810eee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current inline consumer rule failed on the following case, because of the missing inline of the producers of the output stage
Thanks @BBuf for finding this bug