[Bugfix][Thrust] Mark relax.cumsum implementation as scheduled#16688
Closed
Lunderberg wants to merge 1 commit intoapache:mainfrom
Closed
[Bugfix][Thrust] Mark relax.cumsum implementation as scheduled#16688Lunderberg wants to merge 1 commit intoapache:mainfrom
Lunderberg wants to merge 1 commit intoapache:mainfrom
Conversation
Prior to this commit, the `tests/python/relax/test_frontend_nn_op.py::test_renormalize_top_p_top_k_prob` test is failing on the main branch. This is due to use of `tir.transform.DefaultGPUSchedule` on a kernel that cannot be scheduled. This commit updates `relax.backend.DispatchSortScan()` to mark its output `cumsum` function as scheduled.
Member
|
Thanks for the patch. The test should be fixed in #16676. |
Contributor
Author
|
Sounds good, and thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
tests/python/relax/test_frontend_nn_op.py::test_renormalize_top_p_top_k_probtest is failing on the main branch. This is due to use oftir.transform.DefaultGPUScheduleon a kernel that cannot be scheduled.This commit updates
relax.backend.DispatchSortScan()to mark its outputcumsumfunction as scheduled.