[CI][AArch64] Enable ONNX and PyTorch tests on AArch64#16747
[CI][AArch64] Enable ONNX and PyTorch tests on AArch64#16747Liam-Sturge wants to merge 1 commit intoapache:mainfrom
Conversation
This makes use of work done in enabling PyTorch and ONNX tests to be run on AArch64 to actually enable the tests to run as part of CI. Co-Authored-By: Nicola Lancellotti <Nicola.Lancellotti@arm.com> Co-Authored-By: Leandro Nunes <Leandro.Nunes@arm.com>
github-actions
bot
requested review from
NicolaLancellotti,
leandron,
lhutton1,
tqchen and
yongwww
|
I think we should actually avoid running exccessive integration tests across platforms. The unit tests of frontend should only cover the ingestion part ideally (via some lightweight structural equality check). While the UT of the backend should be constructed from the lower-level IR. I know it is harder to do some of that for legacy pipelines, and agree that integration coverage of e2e integration across platforms is useful. One thing we can start doing is to put these tests as scheduled on nightly as opposed to trigger in each PR. |
|
OK, thanks for your feedback @tqchen. I see your point relating to overdoing the testing. Do we currently have any implementation of nightly tests set up that I could append these tests on to? I didn't see anything when I looked, but I may have missed something. |
3 participants
This makes use of work done in enabling PyTorch and ONNX tests to be run on AArch64 to actually enable the tests to run as part of CI.
Co-Authored-By: Nicola Lancellotti Nicola.Lancellotti@arm.com
Co-Authored-By: Leandro Nunes leandro.Nunes@arm.com
cc @leandron @lhutton1 @NicolaLancellotti @tqchen @yongwww