Revert "[FFI][CMAKE] Add missing download path for libbacktrace"#18250
Closed
MasterJH5574 wants to merge 1 commit intomainfrom
Closed
Revert "[FFI][CMAKE] Add missing download path for libbacktrace"#18250MasterJH5574 wants to merge 1 commit intomainfrom
MasterJH5574 wants to merge 1 commit intomainfrom
Conversation
…)" This reverts commit dd1e3f8.
Contributor
Author
|
Closed in observance of #18249. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #18246.
As mentioned in #18246 (comment), it seems that libbacktrace will be re-configured every time and
ffi/src/ffi/traceback.ccwill be compiled when we runmake, even if there is no changes. This repetitive compilation increases the compilation time by a lot.