Skip to content

Conversation

@guan404ming
Copy link
Member

Why

The Embedding module's forward method was using self.dim redundantly when reshaping the output, even though this dimension is already available from self.weight.shape[1].

How

  • Changed shape=[*x.shape, self.dim] to shape=[*x.shape, self.weight.shape[1]] in Embedding.forward

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Embedding module's forward method by ensuring the output dimension is consistently derived from the weight's shape, thereby removing an unnecessary internal dimension attribute. Concurrently, it bolsters the module's test suite by introducing a dedicated test for 1D input tensors, which improves overall coverage and reliability.

Highlights

  • Refactored Embedding.forward: The Embedding.forward method now directly uses self.weight.shape[1] to determine the output shape, eliminating the redundant self.dim attribute and addressing a previous TODO comment.
  • Improved Test Coverage: The existing test_embedding function has been refactored into test_embedding_1d and test_embedding_2d, adding a specific test case for 1D input tensors to enhance the robustness of the Embedding module.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a nice cleanup in the Embedding.forward method by using the shape of the weight tensor directly, instead of relying on self.dim. This change removes redundancy and resolves a TODO comment, improving code clarity. Additionally, the pull request enhances the test suite by splitting the embedding test into separate 1D and 2D input cases, which makes the tests more specific and improves coverage. The changes are correct and well-implemented.

@guan404ming guan404ming marked this pull request as ready for review December 29, 2025 07:06
@guan404ming
Copy link
Member Author

cc @tlopex @mshr-h

@mshr-h mshr-h merged commit d30e347 into apache:main Dec 31, 2025
14 checks passed
@guan404ming guan404ming deleted the fix-embedding-shape-inference branch December 31, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants