[CI] Update images to 20260213-110714-021547fe#18775
[CI] Update images to 20260213-110714-021547fe#18775mshr-h wants to merge 1 commit intoapache:mainfrom
20260213-110714-021547fe#18775Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical infrastructure update for the continuous integration system. It refreshes the Docker images used across various CI environments to a newer version. This update is essential for enabling support for Python 3.10 within the CI pipelines, ensuring that future development and testing can leverage this Python version. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the CI docker image tags in ci/jenkins/docker-images.ini. The change is straightforward and aligns with the goal of using new images that include Python 3.10. I have provided one suggestion to improve the maintainability of this configuration file by reducing redundancy, which could make future updates easier.
| ci_arm: tlcpack/ci-arm:20260213-110714-021547fe | ||
| ci_cpu: tlcpack/ci_cpu:20260213-110714-021547fe | ||
| ci_gpu: tlcpack/ci-gpu:20260213-110714-021547fe | ||
| ci_lint: tlcpack/ci-lint:20260213-110714-021547fe | ||
| ci_wasm: tlcpack/ci-wasm:20260213-110714-021547fe |
There was a problem hiding this comment.
To improve maintainability and reduce redundancy, consider defining the image tag as a variable and reusing it. This would make future updates easier and reduce the chance of inconsistencies. For example, you could add a ci_tag variable under the [jenkins] section and reference it:
ci_tag: 20260213-110714-021547fe
ci_arm: tlcpack/ci-arm:${ci_tag}
ci_cpu: tlcpack/ci_cpu:${ci_tag}
ci_gpu: tlcpack/ci-gpu:${ci_tag}
ci_lint: tlcpack/ci-lint:${ci_tag}
ci_wasm: tlcpack/ci-wasm:${ci_tag}This change would depend on the parser for this file supporting variable interpolation. If that's not feasible, the current explicit approach is acceptable.
Update the CI docker images to include Python 3.10
Part of #18682