[S-TIR][FIX] Remove redundant std::move() to itself

[cbalint13]

I tiny fix shown up by gcc 16

tvm-0.24.0-build/tvm/src/s_tir/transform/lower_cross_thread_reduction.cc: 
    In function ‘tvm::tir::Stmt tvm::s_tir::TransformReductionBlock(const tvm::tir::SBlockRealizeNode*, const tvm::ffi::Optional<tvm::ffi::Array<tvm::tir::Buffer> >&, const tvm::ffi::Array<tvm::tir::Buffer>&, const tvm::ffi::Array<tvm::tir::Buffer>&, const tvm::ffi::Array<tvm::PrimExpr>&, const tvm::tir::CommReducer&, const tvm::ffi::Array<tvm::PrimExpr>&, const std::vector<const tvm::tir::ForNode*>&)’:
tvm-0.24.0-build/tvm/src/s_tir/transform/lower_cross_thread_reduction.cc:356:24: 
    warning: moving ‘new_block.tvm::ffi::ObjectPtr<tvm::tir::SBlockNode>::operator->()->tvm::tir::SBlockNode::reads’ 
    of type ‘tvm::ffi::Array<tvm::tir::BufferRegion>’ to itself [-Wself-move]
  356 |       new_block->reads = std::move(new_block->reads);
      |       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

$ rpm -q gcc-c++
gcc-c++-16.0.1-0.7.fc45.x86_64

---

This is an old leftover from here:
421ff76#diff-ee18021834f82219782c8bbad32b35f73671e6ee498cf3187738c8104611649fL285

- new_block->reads = RemoveBufferFromBufferRegions(std::move(new_block->reads), wb_buffer);
+ new_block->reads = std::move(new_block->reads);

[gemini-code-assist]

Summary of Changes

Hello @cbalint13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compiler warning identified by GCC 16 by removing a redundant std::move operation. The change specifically targets a line where an object was being moved to itself, which had no functional impact but triggered a warning. This cleanup improves code quality and silences unnecessary compiler output.

Highlights

• Redundant std::move() Removal: Removed a std::move(new_block->reads) operation that was moving an object to itself, resolving a -Wself-move warning issued by GCC 16.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/s_tir/transform/lower_cross_thread_reduction.cc
  • Removed a redundant std::move call.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes a redundant std::move of a variable to itself, which was causing a compiler warning with GCC 16. The change is correct and improves code quality by removing this unnecessary self-move. The fix is straightforward and I have no further suggestions.