[CI] Update system cuda version 12.4->12.8#18783
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the CUDA version in the ci_gpu Docker image to fix a cuDNN version mismatch. My review focuses on the potential side effects of this version bump on other dependencies within the image. I've added a comment highlighting the need to update other libraries like JAX and PyTorch which appear to be pinned to older CUDA versions to ensure the overall stability and consistency of the CI environment.
This reverts commit ac70260.
Fix cudnn errors due to version mismatch between system and torch dependency
link to the jenkins log: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-gpu/detail/PR-18775/11/pipeline
validated the fix with the following local ci script