[FIX][Adreno] Replace AllocBuffer with Bind in texture alloc injection

[tqchen]

Summary

• Fix inject_texture_alloc.cc to replace AllocBuffer with just a Bind(nd_mem_alloc_with_scope), consistent with LowerVtcmAlloc
• Previously kept a redundant AllocBuffer alongside the Bind in a SeqStmt

Follow-up to #18876.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the texture allocation injection mechanism within the Adreno backend. It resolves an inconsistency by removing a redundant allocation step and aligning the implementation with established memory allocation patterns, thereby enhancing code clarity and efficiency.

Highlights

• Adreno Texture Allocation Fix: Replaced the AllocBuffer call with a direct Bind(nd_mem_alloc_with_scope) in inject_texture_alloc.cc to ensure consistency with LowerVtcmAlloc and eliminate redundant allocation logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/s_tir/backend/adreno/inject_texture_alloc.cc
  • Removed the ffi::Array<Stmt> seq and SeqStmt construct that previously wrapped the allocation logic.
  • Directly assigned the Bind call to stmt, streamlining the texture memory allocation process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug in the texture allocation injection for the Adreno backend. The change removes a redundant AllocBuffer statement that was generated along with a Bind to nd_mem_alloc_with_scope. The previous implementation would first allocate a standard buffer and then immediately re-bind the buffer variable to a texture allocation, which could lead to a memory leak. By replacing the AllocBuffer entirely with the Bind statement, this change fixes the issue and makes the code cleaner and more correct. The fix is consistent with similar logic in other parts of the codebase.