Skip to content

[Metal] Include logging headers for metal#19493

Merged
tlopex merged 1 commit intoapache:mainfrom
akaashrp:metal
May 2, 2026
Merged

[Metal] Include logging headers for metal#19493
tlopex merged 1 commit intoapache:mainfrom
akaashrp:metal

Conversation

@akaashrp
Copy link
Copy Markdown
Contributor

@akaashrp akaashrp commented May 1, 2026

Metal files were using LOG macros without including the necessary logging header

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the tvm/runtime/logging.h header to metal_device_api.mm and metal_module.mm. I have no feedback to provide as there are no review comments.

@tlopex tlopex merged commit baec626 into apache:main May 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants