Skip to content

[BugFix][Vulkan][CodeGen] Change OpControlBarrier to AcquireRelease#19619

Merged
tqchen merged 1 commit into
apache:mainfrom
kistenklaus:main
May 27, 2026
Merged

[BugFix][Vulkan][CodeGen] Change OpControlBarrier to AcquireRelease#19619
tqchen merged 1 commit into
apache:mainfrom
kistenklaus:main

Conversation

@kistenklaus
Copy link
Copy Markdown
Contributor

@kistenklaus kistenklaus commented May 27, 2026 •
edited
Loading

Fixes #18915

Vulkan codegen previously generated sequentially constistant OpControlBarrier SPIR-V instructions, which is invalid for Vulkan, where we would expect AcquireRelease.

@kistenklaus
[BugFix][Vulkan][CodeGen] Change OpControlBarrier to AcquireRelease
e7a3394 
Fixes apache#18915
May be related to apache#3487

Vulkan codegen previously generated sequentially constistant OpControlBarrier SPIR-V instructions, which is invalid for Vulkan, where we would expect AcquireRelease.
@kistenklaus
Copy link
Copy Markdown
Contributor Author

kistenklaus commented May 27, 2026

resubmit of #19608

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the memory semantics in CodeGenSPIRV::CreateStorageSync from SequentiallyConsistentMask to AcquireReleaseMask for Vulkan SPIR-V code generation. There are no review comments, and I have no additional feedback to provide.

@tqchen
Copy link
Copy Markdown
Member

tqchen commented May 27, 2026

@tvm-bot rerun

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Failed to re-run CI in https://github.com/apache/tvm/actions/runs/26513233368

Details 
Traceback (most recent call last):
  File "/home/runner/work/tvm/tvm/ci/scripts/github/github_tvmbot.py", line 589, in comment_failure
    raise item
  File "/home/runner/work/tvm/tvm/ci/scripts/github/github_tvmbot.py", line 695, in run
    pr.rerun_jenkins_ci()
  File "/home/runner/work/tvm/tvm/ci/scripts/github/github_tvmbot.py", line 548, in rerun_jenkins_ci
    post(url, auth=("tvm-bot", TVM_BOT_JENKINS_TOKEN))
  File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 54, in post
    with request.urlopen(req, data) as response:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 215, in urlopen
    return opener.open(url, data, timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 521, in open
    response = meth(req, response)
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 630, in http_response
    response = self.parent.error(
               ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 559, in error
    return self._call_chain(*args)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 492, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 639, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: Bad Request

with response

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 400 tvm-docker/PR-19619 is not parameterized</title>
</head>
<body><h2>HTTP ERROR 400 tvm-docker/PR-19619 is not parameterized</h2>
<table>
<tr><th>URI:</th><td>/job/tvm-docker/job/PR-19619/buildWithParameters</td></tr>
<tr><th>STATUS:</th><td>400</td></tr>
<tr><th>MESSAGE:</th><td>tvm-docker/PR-19619 is not parameterized</td></tr>
<tr><th>SERVLET:</th><td>Stapler</td></tr>
</table>
<hr/><a href="https://jetty.org/">Powered by Jetty:// 12.0.25</a><hr/>

</body>
</html>

@tqchen
Copy link
Copy Markdown
Member

tqchen commented May 27, 2026

@tvm-bot rerun

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Failed to re-run CI in https://github.com/apache/tvm/actions/runs/26528155057

Details 
Traceback (most recent call last):
  File "/home/runner/work/tvm/tvm/ci/scripts/github/github_tvmbot.py", line 589, in comment_failure
    raise item
  File "/home/runner/work/tvm/tvm/ci/scripts/github/github_tvmbot.py", line 695, in run
    pr.rerun_jenkins_ci()
  File "/home/runner/work/tvm/tvm/ci/scripts/github/github_tvmbot.py", line 548, in rerun_jenkins_ci
    post(url, auth=("tvm-bot", TVM_BOT_JENKINS_TOKEN))
  File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 54, in post
    with request.urlopen(req, data) as response:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 215, in urlopen
    return opener.open(url, data, timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 521, in open
    response = meth(req, response)
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 630, in http_response
    response = self.parent.error(
               ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 559, in error
    return self._call_chain(*args)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 492, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/usr/lib/python3.12/urllib/request.py", line 639, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: Bad Request

with response

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 400 tvm-docker/PR-19619 is not parameterized</title>
</head>
<body><h2>HTTP ERROR 400 tvm-docker/PR-19619 is not parameterized</h2>
<table>
<tr><th>URI:</th><td>/job/tvm-docker/job/PR-19619/buildWithParameters</td></tr>
<tr><th>STATUS:</th><td>400</td></tr>
<tr><th>MESSAGE:</th><td>tvm-docker/PR-19619 is not parameterized</td></tr>
<tr><th>SERVLET:</th><td>Stapler</td></tr>
</table>
<hr/><a href="https://jetty.org/">Powered by Jetty:// 12.0.25</a><hr/>

</body>
</html>

@tqchen tqchen merged commit 7c21470 into apache:main May 27, 2026
11 checks passed
@kistenklaus
Copy link
Copy Markdown
Contributor Author

kistenklaus commented May 27, 2026

thanks for maintaining <3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchen tqchen tqchen approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug][Vulkan] SPIR-V backend generates sequentially consistant OpControlBarriers and OpMemberDecorate DecorationOffset on non-interface blocks

2 participants

@kistenklaus @tqchen