More CHECK to ICHECK#6758
Merged
jroesch merged 4 commits intoapache:mainfrom Oct 26, 2020
rkimball:bob/err2
Merged
Conversation
Member
|
The NNVM code is mostly dead code but looks good to me. |
jroesch
approved these changes
Oct 26, 2020
zhiics
pushed a commit
to zhiics/tvm
that referenced
this pull request
Oct 28, 2020
* Address apps, docs, and nnvm directories * Catch some that were missed * crt has it's own logging.h * Fix missing include
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
* Address apps, docs, and nnvm directories * Catch some that were missed * crt has it's own logging.h * Fix missing include
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* Address apps, docs, and nnvm directories * Catch some that were missed * crt has it's own logging.h * Fix missing include
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* Address apps, docs, and nnvm directories * Catch some that were missed * crt has it's own logging.h * Fix missing include
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* Address apps, docs, and nnvm directories * Catch some that were missed * crt has it's own logging.h * Fix missing include
Member
|
I don't think change to the NNVM directory is right - NNVM does not rely on the rest of TVM so it does not know about |
Member
|
@ptrendx you are right, please send another PR to revert the change in NNVM part |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.