Skip to content

Fix use of wrong variable#8227

Merged
jcf94 merged 2 commits intoapache:mainfrom
serkm:fix_var
Jun 10, 2021
Merged

Fix use of wrong variable#8227
jcf94 merged 2 commits intoapache:mainfrom
serkm:fix_var

Conversation

@serkm
Copy link
Contributor

@serkm serkm commented Jun 9, 2021

The function argument is named kernel and these lines used filter instead.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. You might also want to fix the docstring, which is still filter for that argument.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcf94 jcf94 merged commit d767659 into apache:main Jun 10, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
* Fix use of wrong variable

* Fix docstrings
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
* Fix use of wrong variable

* Fix docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants