[BUG FIX] Add _type_has_method_sequal_reduce to Span and SourceNode#8248
Merged
masahi merged 2 commits intoapache:mainfrom Jun 15, 2021
Merged
[BUG FIX] Add _type_has_method_sequal_reduce to Span and SourceNode#8248masahi merged 2 commits intoapache:mainfrom
masahi merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Thanks @masahi! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8248) * add field _type_has_method_sequal_reduce to Span and SourceName * retrigger CI
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8248) * add field _type_has_method_sequal_reduce to Span and SourceName * retrigger CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span and SourceName have the methods
SEqualReducebut do not have the field_type_has_method_sequal_reduce, which causes failures if you try to assert_structural_equal on ASTs containing Spans or SourceNames.This PR adds _type_has_method_sequal_reduce to Span and SourceName.
@mbrookhart @tkonolige could you take a look? Thanks