[Graph Debug Executor] Add exception for profile with remote devices#8345
Closed
mehrdadh wants to merge 2 commits intoapache:mainfrom
Closed
[Graph Debug Executor] Add exception for profile with remote devices#8345mehrdadh wants to merge 2 commits intoapache:mainfrom
mehrdadh wants to merge 2 commits intoapache:mainfrom
Conversation
mehrdadh
force-pushed
the
profile_exception
branch
from
06d8282 to
7be5c03
Compare
This was referenced Jun 25, 2021
mehrdadh
force-pushed
the
profile_exception
branch
from
65ad940 to
3cdd87e
Compare
areusch
reviewed
Jun 28, 2021
| self._profile = module["profile"] | ||
| graph_executor.GraphModule.__init__(self, module) | ||
| self._create_debug_env(graph_json_str, device) | ||
| self._device = device[0] |
Contributor
There was a problem hiding this comment.
i'm worried that the cpu device might not be first in the list. maybe we should just store a local flag e.g. self._has_remote_device = any(d.device_type >= base.RPC_SESS_MASK for d in device)
and use that?
tkonolige
reviewed
Jun 28, 2021
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
I believe I tested profiling on remote devices and it worked. Could you provide the error you are getting when profiling on a remote device?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
cc @areusch