[MetaSchedule] Fix comments in instruction traits#9614
Merged
masahi merged 1 commit intoapache:mainfrom Dec 6, 2021
Merged
Conversation
vinx13
requested review from
Hzfengsy,
ZihengJiang,
junrushao,
kparzysz-quic,
masahi and
tqchen
as code owners
junrushao
approved these changes
Nov 30, 2021
Hzfengsy
approved these changes
Dec 1, 2021
Member
|
Could you please re-trigger the CI? |
vinx13
force-pushed
the
fix/inst_trait
branch
from
6897c75 to
e845f58
Compare
Member
|
Looks like we need to retrigger the CI again |
vinx13
force-pushed
the
fix/inst_trait
branch
from
e845f58 to
73713ca
Compare
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in the comment is inconsistent with https://github.com/apache/tvm/blob/main/include/tvm/tir/schedule/instruction.h#L61-L75
@junrushao1994