[microNPU] removing extra bytes for workspace#9629
Merged
leandron merged 1 commit intoapache:mainfrom Dec 2, 2021
Merged
Conversation
Given that microNPU codegen uses target hooks it undergoes the core compiler that updates workspace sizes. We dont need the additional sizes anymore. This commit removes the sizes. Change-Id: Ifd2a01e5f9566ee0c37778f32392d6d1f8c7c091
manupak
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
Contributor
Author
|
cc : @leandron @grant-arm @Mousius |
Member
|
Does it make sense to remove this field all together vs. just setting it to zero? |
Contributor
Author
|
@jroesch I think its still useful in cases where stack allocator is used in debug mode where tags are stored in the workspace itself. Thus, the workspace required would be larger than what TIR would say. E.g. : tvm/tests/python/relay/aot/test_crt_aot.py Line 317 in b4cc3ba |
leandron
approved these changes
Dec 2, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM, thanks @manupa-arm!
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Given that microNPU codegen uses target hooks it undergoes the core compiler that updates workspace sizes. We dont need the additional sizes anymore. This commit removes the sizes. Change-Id: Ifd2a01e5f9566ee0c37778f32392d6d1f8c7c091
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
Given that microNPU codegen uses target hooks it undergoes the core compiler that updates workspace sizes. We dont need the additional sizes anymore. This commit removes the sizes. Change-Id: Ifd2a01e5f9566ee0c37778f32392d6d1f8c7c091
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
Given that microNPU codegen uses target hooks it undergoes the core compiler that updates workspace sizes. We dont need the additional sizes anymore. This commit removes the sizes. Change-Id: Ifd2a01e5f9566ee0c37778f32392d6d1f8c7c091
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Given that microNPU codegen uses target hooks it undergoes the core compiler that updates workspace sizes. We dont need the additional sizes anymore. This commit removes the sizes. Change-Id: Ifd2a01e5f9566ee0c37778f32392d6d1f8c7c091
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
Given that microNPU codegen uses target hooks it undergoes the core compiler that updates workspace sizes. We dont need the additional sizes anymore. This commit removes the sizes. Change-Id: Ifd2a01e5f9566ee0c37778f32392d6d1f8c7c091
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that microNPU codegen uses target hooks
it goes through the core compiler that updates
workspace sizes. We dont need the additional
sizes anymore. This commit removes the sizes.