[Relay][Quantization] Fq2i hard fail option#9660
Merged
jwfromm merged 1 commit intoapache:mainfrom Dec 10, 2021
Merged
Conversation
mbrookhart
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
mbrookhart
force-pushed
the
fq2i_hard_fail_option
branch
from
d77c094 to
8ccefc6
Compare
add test fix lint, rework hard fail conditionals apparently clang-format didn't take last time I tried I can haz overflowing comments
mbrookhart
force-pushed
the
fq2i_hard_fail_option
branch
from
8ccefc6 to
c75e9c0
Compare
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
add test fix lint, rework hard fail conditionals apparently clang-format didn't take last time I tried I can haz overflowing comments
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
add test fix lint, rework hard fail conditionals apparently clang-format didn't take last time I tried I can haz overflowing comments
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
add test fix lint, rework hard fail conditionals apparently clang-format didn't take last time I tried I can haz overflowing comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
add test fix lint, rework hard fail conditionals apparently clang-format didn't take last time I tried I can haz overflowing comments
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
add test fix lint, rework hard fail conditionals apparently clang-format didn't take last time I tried I can haz overflowing comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds error handling to the Fake Quantization to integer to catch issues during graph rewrite and abort the rewrite.
Alternatively, it adds an option to fail if those rewrites fail or if we find missing ops, which should allow for easier debugging.
cc @anwang2009 @michalpiszczek @AndrewZhaoLuo @masahi