[Torch] Frontend update to support PyTorch 1.10#9664
Merged
masahi merged 10 commits intoapache:mainfrom Dec 7, 2021
Merged
Conversation
masahi
requested review from
Huyuwei,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
comaniac
approved these changes
Dec 6, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM. I guess these changes are backward compatible so this PR can still pass the current CI? If so then I'm totally fine with it. In case something broken with PT 1.10, we will find them out when updating the docker image.
Member
Author
Yes absolutely, the change is backward compatible. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* wip * fixed converting maskrcnn * fixed nll los * fixed linspace * fixed deformable conv2d * control flow and rnn test had no problem * swap more import orders * qmv3 test is having weird segfault * cleanup * black
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* wip * fixed converting maskrcnn * fixed nll los * fixed linspace * fixed deformable conv2d * control flow and rnn test had no problem * swap more import orders * qmv3 test is having weird segfault * cleanup * black
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
* wip * fixed converting maskrcnn * fixed nll los * fixed linspace * fixed deformable conv2d * control flow and rnn test had no problem * swap more import orders * qmv3 test is having weird segfault * cleanup * black
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* wip * fixed converting maskrcnn * fixed nll los * fixed linspace * fixed deformable conv2d * control flow and rnn test had no problem * swap more import orders * qmv3 test is having weird segfault * cleanup * black
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
* wip * fixed converting maskrcnn * fixed nll los * fixed linspace * fixed deformable conv2d * control flow and rnn test had no problem * swap more import orders * qmv3 test is having weird segfault * cleanup * black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9349
I was originally planning to send this change along with docker image update, but I've been pushing docker update work in favor of other higher priority tasks. Since people might start using TVM with PT 1.10 by now, I thought I'd send frontend update first.
Though the change won't be tested on CI until docker update lands, I've confirmed locally that all tests passed with PT 1.10 using this change (in particular, the MaskRCNN test requires this change). I promise I'll work on docker update this month 😅
What do you think? @comaniac @Laurawly @jcf94